Add conversion from Zarr array to tensorstore #150
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR, @ilan-francisco. I have a few minor comments:
@ziw-liu , will |
Contributor
This sounds like the best solution as the compiled extension of tensorstore is not available on every platform. If we do go this route then this PR (and future ones using ts) will need to handle import errors. |
ziw-liu
reviewed
Jun 21, 2023
| raise NotImplementedError | ||
| import tensorstore as ts | ||
|
|
||
| assert self.path != "", "Zarr array must be stored on a file system." |
Contributor
There was a problem hiding this comment.
In theory an iohub NGFF store is always on a local mounted FS, so this might be redundant.
Closed
ziw-liu
added
enhancement
Contributor
|
@JoOkuma Is further follow-up work expected for this PR? |
Contributor
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling tensorstore conversion from a zarr array, as mentioned in #26.